Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several leaks in tests #225

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix several leaks in tests #225

merged 1 commit into from
Nov 8, 2021

Conversation

dylanahsmith
Copy link
Collaborator

In order to address #222, we need to avoid leaks in the tests as well as the code under test, since we currently depend on code using the library to dispose isolates and close contexts to avoid memory leaks.

This PR just adds the missing Isolate.Dispose and Context.Close calls that came up from using clang's address sanitizer.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #225 (9e708a4) into master (24e3ca7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          16       16           
  Lines         545      545           
=======================================
  Hits          521      521           
  Misses         15       15           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e3ca7...9e708a4. Read the comment docs.

@dylanahsmith dylanahsmith merged commit a582436 into master Nov 8, 2021
@dylanahsmith dylanahsmith deleted the test-leak-fixes branch November 8, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants