Compile with warnings and fix exiting warnings #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easy to make some stupid mistakes that wastes some time debugging when the compiler could have pointer out the problem. Using
-Wall
(with gcc/clang) will enable warnings for errors that compilers can detect.I've addressed the existing warnings in the first few commits. I enabled compiler warnings by default when compiling locally. Additionally, I used
-Werror
to treat warnings as errors in CI.I chose not to treat warnings as errors locally, mostly because of experience with lint like errors interrupting the development/debug feedback loop when they aren't really relevant. Although, this is kind of a philosophical divergence from Go (e.g. how it warns about unused imports when adding in import "fmt" for debugging), so I can enable
-Werror
locally if other v8go devs disagree.