Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless print statement in a test #232

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

dylanahsmith
Copy link
Collaborator

I also changed the test since it was originally for isolate garbage collection, which is no longer done, but is still useful for template garbage collection that is still done.

Isolates aren't garbaged collected at the moment. I think they may have
been in the past though.
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #232 (8b5131a) into master (11de938) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b5131a differs from pull request most recent head 95cc948. Consider uploading reports for the commit 95cc948 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          17       17           
  Lines         580      580           
=======================================
  Hits          556      556           
  Misses         15       15           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11de938...95cc948. Read the comment docs.

@dylanahsmith dylanahsmith merged commit 64149e7 into master Nov 17, 2021
@dylanahsmith dylanahsmith deleted the test-remove-print branch November 17, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants