Support []byte in Value #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedzielski
suggested changes
Jan 18, 2023
| std::unique_ptr<BackingStore> bs = ArrayBuffer::NewBackingStore( | ||
| static_cast<void*>(const_cast<uint8_t*>(v)), len, | ||
| [](void* data, size_t length, void *deleter_data) { | ||
| free(data); |
There was a problem hiding this comment.
As far as I can tell, this seems to be the correct deallocator to use but I couldn't find a convincing example.
| // Returns length of the array (number of elements, not number of bytes) | ||
| uint64_t ValueToArrayLength(ValuePtr ptr) { | ||
| LOCAL_VALUE(ptr); | ||
| MaybeLocal<TypedArray> array = value.As<TypedArray>(); |
There was a problem hiding this comment.
Do we need to check if this is empty?
uint64_t ValueToArrayLength(ValuePtr ptr) {
LOCAL_VALUE(ptr);
MaybeLocal<TypedArray> array = value.As<TypedArray>();
if (array.IsEmpty()) {
return 0;
}
return array.ToLocalChecked()->Length();
}
Same question above in ValueToUint8Array().
Codecov ReportBase: 95.28% // Head: 95.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 95.28% 95.33% +0.04%
==========================================
Files 17 17
Lines 594 600 +6
==========================================
+ Hits 566 572 +6
Misses 19 19
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reduction of the longstanding #143 to do the minimum I actually need: letting me put []byte's into and out of values.