Make hashes use unsigned

This avoids undefined behaviour. Fixes #274
rogerbinns · Oct 17, 2019 · d4d16c2 · d4d16c2
1 parent e77fa2a
commit d4d16c2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/doc/changes.rst b/doc/changes.rst
@@ -2,12 +2,14 @@ Change History
 **************
 .. currentmodule:: apsw
 
-3.30.0-r1
+3.30.1-r1
 =========
 
 Added constants:
 
-* SQLITE_DBCONFIG_ENABLE_VIEW 
+* SQLITE_DBCONFIG_ENABLE_VIEW
+
+Updated of SQL statements (:issue:`274`)
 
 3.29.0-r1
 =========

diff --git a/src/apswbuffer.c b/src/apswbuffer.c
@@ -98,10 +98,10 @@ APSWBuffer_fini(void)
    they can also use a hash seed which alters the value.  There is no need
    for this hash and strings/bytes etc be the same, but usually they are.  We
    add an extra 1 to put APSWBuffer into a different hash bucket. */
-static long
+static Py_hash_t
 APSWBuffer_hash(APSWBuffer *self)
 {
-  long hash;
+  Py_hash_t hash;
   unsigned char *p;
   Py_ssize_t len;
 

diff --git a/src/pyutil.c b/src/pyutil.c
@@ -10,6 +10,10 @@
 typedef int Py_ssize_t;
 #endif
 
+#if PY_VERSION_HEX < 0x03020000
+typedef unsigned long Py_hash_t;
+#endif
+
 /* Python 2.3 doesn't have these */
 #ifndef Py_RETURN_NONE
 #define Py_RETURN_NONE return Py_INCREF(Py_None), Py_None