Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DisableTerminalOutput setting to CLI #46

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Apr 13, 2023

This is useful for shell-scripting when used in combination with another exporter (like raw CSV or Cloudwatch or Prometheus)

It just exposes the flag -s or --silent, so you can use even the CLI tool noninteractively. For shell-users, who are much better in programming bash/zsh it is easier for them instead of using cassowary as a Go library.

@rogerwelin rogerwelin self-requested a review April 13, 2023 11:07
Copy link
Owner

@rogerwelin rogerwelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes removes the spinner and status-text but you also need to disable the metrics being printed to the console.

in the runLoadTest func please do the following:

if !c.DisableTerminalOutput {
   outPutResults(metrics)
}

This is useful for shell-scripting when used in combination with another
exporter (like raw CSV or Cloudwatch or Prometheus)
@bebehei
Copy link
Contributor Author

bebehei commented Apr 24, 2023

I've added the requested change by you, @rogerwelin.

@rogerwelin rogerwelin merged commit 76a44cd into rogerwelin:master Apr 26, 2023
@rogerwelin
Copy link
Owner

Thank you @bebehei for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants