Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command go allowed in some txtar scripts and not in others, please document #234

Closed
rudifa opened this issue Aug 8, 2023 · 2 comments
Closed

Comments

@rudifa
Copy link
Contributor

rudifa commented Aug 8, 2023

I was intrigued by the difference between .txtar files intended for running with testscript first.txtar and those intended for running with go test other.txtar.

The files ran by testscript support the command go with a variety of arguments, as documented in testscript -h, in addition to commands, conditions and supporting files that are interpreted by the small script engine in the testscript package; files run by go test do not support the command go.

I suggest that this difference should be mentioned and documented in testscript doc, for the benefit of newcomers.

@mvdan
Copy link
Collaborator

mvdan commented Mar 8, 2024

The difference is https://pkg.go.dev/github.com/rogpeppe/go-internal/gotooltest. It's true that the gotooltest package is not linked from the testscript package's documentation, so I'd happily approve a small patch doing that.

@mvdan
Copy link
Collaborator

mvdan commented Apr 15, 2024

Your PR above clarified this.

@mvdan mvdan closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants