-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/testscript: support -update flag #121
Conversation
45ea8d3
to
2e06fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! AFAICS there are still a couple of issues the need fixing (or at least test cases adding for them if my assessment is flawed)...
4e70325
to
47e2b36
Compare
Thanks for the review, @rogpeppe. All comments addressed, with one small question by way of reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one last thing to do (wouldn't it be nice to have only one copy of the help text?), thanks!
This is exactly equivalent to setting testscript.Params.UpdateScripts
47e2b36
to
4408f18
Compare
No description provided.