testscript: workaround quardratic behaviour of github.com/pkg/diff #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Mar 29, 2021
The current version of github.com/pkg/diff.Diff has quadratic behaviour. This means that when we attempt a diff between relatively modest sized files, it's easy to find yourself out of memory. Therefore, when we see a diff between two large files (large defined in terms of number of lines), tersely report that as if the two were binary files, i.e. do not try to render the diff. When github.com/pkg/diff or similar supports a linear algorithm: golang/go#45200 (comment) we can revert this change.
myitcv
force-pushed
the
testscript_workaround_large_diff
branch
from
ec57b52
to
8329eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of github.com/pkg/diff.Diff has quadratic behaviour.
This means that when we attempt a diff between relatively modest sized
files, it's easy to find yourself out of memory.
Therefore, when we see a diff between two large files (large defined in
terms of number of lines), tersely report that as if the two were binary
files, i.e. do not try to render the diff.
When github.com/pkg/diff or similar supports a linear algorithm:
golang/go#45200 (comment)
we can revert this change.