Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testscript: add support for Go master aka 1.18 #145

Merged
merged 1 commit into from
Sep 23, 2021
Merged

testscript: add support for Go master aka 1.18 #145

merged 1 commit into from
Sep 23, 2021

Conversation

mvdan
Copy link
Collaborator

@mvdan mvdan commented Sep 22, 2021

(see commit message)

@mvdan mvdan force-pushed the support-1.18 branch 2 times, most recently from 2c163ac to 6f57cb6 Compare September 22, 2021 16:30
myitcv
myitcv approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'll declare I'm not too familiar with the fuzzy stuff

rogpeppe
rogpeppe approved these changes Sep 23, 2021
View reviewed changes
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

testscript/exe_go118.go Show resolved Hide resolved
@mvdan @rogpeppe
testscript: add support for Go master aka 1.18
ffb0322 
Fuzzing support brought a new parameter to MainStart,
as well as more methods on testDeps.
Use build tags to support those without breaking 1.16 nor 1.17.

While at it, bump CI to test the two latest Go versions,
and run 1.17's gofmt, as CI demands it.

Finally, make CI also test with Go's master version,
to ensure that we are compatible with it.
We pin a specific commit, since that keeps CI stable.

Fixes rogpeppe#144.

Co-authored-by: Roger Peppe <rogpeppe@gmail.com>
@mvdan
Copy link
Collaborator Author

mvdan commented Sep 23, 2021

@rogpeppe @myitcv test-gotip is now added. It takes about 3m, compared to just under 1m for the stable version. That is to be expected, as building from source takes between a minute and two on average hardware.

@myitcv
Copy link
Collaborator

myitcv commented Sep 23, 2021

Still LGTM. Thank you for going the extra mile 😄

@mvdan mvdan merged commit 86f73c5 into rogpeppe:master Sep 23, 2021
@mvdan mvdan deleted the support-1.18 branch September 23, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myitcv myitcv myitcv approved these changes

@rogpeppe rogpeppe rogpeppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdan @myitcv @rogpeppe