Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testscript: add Go compiler and version conditions #154

Merged
merged 4 commits into from
Mar 12, 2022
Merged

testscript: add Go compiler and version conditions #154

merged 4 commits into from
Mar 12, 2022

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Mar 2, 2022

As suggested by @mvdan in #150 (comment). Replaces #150.

@twpayne twpayne mentioned this pull request Mar 2, 2022
Closed
mvdan
mvdan approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM as long as we remove the now unnecessary code in gotooltest.

gotooltest/setup.go Outdated Show resolved Hide resolved
mvdan
mvdan approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure why mac timed out.

@mvdan mvdan merged commit 3461ca1 into rogpeppe:master Mar 12, 2022
@twpayne twpayne deleted the go-conditions branch March 14, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twpayne @mvdan