Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: add Params.RequireExplicitExec #164

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

mvdan
Copy link
Collaborator

@mvdan mvdan commented Jun 28, 2022

(see commit message)

Fixes #163.

Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM in general modulo a few comments and suggestions.

testscript/cmd.go Outdated Show resolved Hide resolved
testscript/exe.go Outdated Show resolved Hide resolved
We also document how top-level commands fed to RunMain work with and
without "exec" the same way, and how RequireExplicitExec can drop
backwards compatibility for greater consistency.

Fixes rogpeppe#163.
@mvdan
Copy link
Collaborator Author

mvdan commented Jul 6, 2022

@rogpeppe ready for a final approval, I think.

Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mvdan mvdan merged commit 9d15b66 into rogpeppe:master Jul 6, 2022
@mvdan mvdan deleted the require-explicit-exec branch July 21, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggest using exec foo for top-level commands rather than foo for consistency
2 participants