Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deadkeys that do not require a modifier key to work #246

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

bambu
Copy link
Contributor

@bambu bambu commented Apr 17, 2016

Improved deadkey recognition. Now it should work on layouts where a modifier key is not required for deadkeys. This pr is for issue #221. I tested it with a greek layout and it seemed to work fine with the ;e being έ. I also tried other random letters and was able to get άίόύ.

@rogual
Copy link
Owner

rogual commented Apr 20, 2016

Thank you!

@rogual rogual merged commit 93ce5f1 into rogual:master Apr 20, 2016
@nrontsis
Copy link

nrontsis commented Apr 20, 2016

@bambu Thank you for the PR! I was about to write about it. It works fine and it fixes #221! The only difference with MacVim is that when typing ; it goes into im insert mode indicating that a potential modifier key was typed (a similar thing happens when running inside a terminal); this does not affect the functionality in any way though.

@nrontsis nrontsis mentioned this pull request Apr 20, 2016
@bambu bambu mentioned this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants