Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macmeta support #250

Merged
merged 3 commits into from
Apr 30, 2016
Merged

Added macmeta support #250

merged 3 commits into from
Apr 30, 2016

Conversation

bambu
Copy link
Contributor

@bambu bambu commented Apr 22, 2016

Added macmeta support as requested in #249 and #86. This only translates the Meta/Alt/Option key as such. It does not interpret the Command key as a Meta key. This can be turned on by calling:

call MacSetMacmeta(1)

@bambu bambu mentioned this pull request Apr 22, 2016
@nrontsis
Copy link

Thanks a bunch! Works fine. 👍

Any reason why you went with call MacSetMacmeta(1) instead of set macmeta?

@rogual
Copy link
Owner

rogual commented Apr 25, 2016

There's no Neovim API to add new set commands.

@rogual
Copy link
Owner

rogual commented Apr 25, 2016

Looks good to me @bambu. Before I merge this, can anyone think of a more descriptive name than MacSetMacmeta?

I'd rather go for self-explanatory over MacVim-compatible if possible. Happy to merge otherwise, but it won't be easy to change later.

@bambu
Copy link
Contributor Author

bambu commented Apr 25, 2016

How about MacSetOptionAsMeta()? That is similar to what Terminal / iterm2 call there setting.

@rogual
Copy link
Owner

rogual commented Apr 25, 2016

I like that.

Merge remote-tracking branch 'upstream/master' into macmeta
@bambu
Copy link
Contributor Author

bambu commented Apr 25, 2016

updated

@rogual rogual merged commit d6ef684 into rogual:master Apr 30, 2016
@rogual
Copy link
Owner

rogual commented Apr 30, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants