Fixes for the VC Bundle with Git on Windows #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These extra escape characters are needed in the git pretty format so they are not replaced by variables in the batch script. Signed-off-by: Nathaniel Struselis <Nathaniel.Struselis@hotmail.co.uk>
Signed-off-by: Nathaniel Struselis <Nathaniel.Struselis@hotmail.co.uk>
NathanielJS1541
force-pushed
the
git-windows_fixes
branch
from
164184b
to
700b786
Compare
|
Sorry, just rebased my commits to include the signed-off-by line. |
NathanielJS1541
added a commit
to NathanielJS1541/LaTeX_Template
that referenced
this pull request
Sep 9, 2024
These files are taken from a pull request I recently opened (rohieb/ctan-support-vc#4) which fixes a couple of issues with the vc bundles specific to git on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of issues that meant that functionality of the vc bundle when using
giton Windows just didn't work at all.I have opened #2 and #3 to report these issues, and since the issues are fairly simple to fix I have opened this PR with my suggestions.
However, in light of this it may be worth checking the consistency of the other platforms and version control types. I would do this, but I only work with
git.EDIT:
I've browsed the source, and it seems that only the mercurial template uses
Abr. Hash:rather thanAbrHash:etc. I still think movinggit-windows/vc.batinline withgit-unix/vcis the right call so there are no differences between thevc-git.awkfiles.EDIT 2:
I've also checked the rest of the
.batfiles, and none of the rest of them need escaping either.