Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorisation Dropdown background color fix #232

Closed
wants to merge 2 commits into from
Closed

Authorisation Dropdown background color fix #232

wants to merge 2 commits into from

Conversation

Snivio
Copy link
Contributor

@Snivio Snivio commented Sep 12, 2022

Dropdown Code block Has Contrast Issue in Dark Mode #231

@Snivio
Authorisation Dropdown background color fix
fa4c4d0 
Dropdown Code block Has Contrast Issue in Dark Mode rohit-gohri#231
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2b8d31f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @rohit-gohri on Vercel.

@rohit-gohri first needs to authorize it.

@Snivio
Copy link
Contributor Author

Snivio commented Sep 12, 2022

Updated so that the dropdown color is changed only when toggeled

@vercel
Copy link

vercel bot commented Sep 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
redocusaurus ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 7:34PM (UTC)

@Snivio Snivio mentioned this pull request Sep 13, 2022
Open
rohit-gohri
rohit-gohri reviewed Nov 30, 2022
View reviewed changes
packages/docusaurus-theme-redoc/src/theme/Redoc/styles.css
@@ -195,3 +195,8 @@ html:not([data-theme='dark']) .redocusaurus div[id^='react-tabs'] code {
.redocusaurus table.security-details tr:nth-child(2n + 1) {
background-color: var(--ifm-background-surface-color);
}

/* Authorisation Dropdown background color fix */
[data-theme='dark'] .redocusaurus .api-content .sc-jQHtVU:has(span > span > code) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.sc-jQHtVU class name will change whenever there is a new build of redoc available so I don't think this fix should be merged. There should be a better way to do this

@rohit-gohri rohit-gohri closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-gohri rohit-gohri rohit-gohri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snivio @rohit-gohri