Fix for Windows #18
Open
Fix for Windows #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OolaaPleur Thank you for the PR! Could you make only the minimal changes? This would make the review process easier. It seems like you’re just parsing the characteristic outside of uiThreadHandler and passing the resulting Char String instead of GattLocalChar. Or am I missing something else? |
|
Yeah, I guess. I never touched C++. Parsing it outside stopped it from localChar being null pointer on my PC (on laptop all works fine). This fixed my problem of crashing ble_peripheral and uni_control_hub. May be its not a good fix, at least I hope it will give some ideas, why on some hardwares app is crashing. |
|
@OolaaPleur i see, thats strange, are you sure localChar is null on your Pc ? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.