-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐕 woof woof #7
base: main-nuxt
Are you sure you want to change the base?
🐕 woof woof #7
Conversation
You're Pull Request scored a 0.005291005291005291 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR: |
try { | ||
const { headers } = await api.head(assetUrl) | ||
return headers['content-type'] | ||
} catch (e: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
plugins/metaInfo.ts
Outdated
@@ -1,4 +1,4 @@ | |||
import Vue from 'vue' | |||
import MetaInfo from 'vue-meta' | |||
|
|||
Vue.use(MetaInfo) | |||
Vue.use(MetaInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { APIKeys, pinFile as pinFileToIPFS } from './pinata'; | ||
import { extractCid, justHash } from './utils/ipfs'; | ||
import Axios from 'axios' | ||
import { NFT, NFTMetadata } from './components/rmrk/service/scheme' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
'NFT' is defined but never used. @typescript-eslint/no-unused-vars
import { InjectedAccountWithMeta } from '@polkadot/extension-inject/types'; | ||
import { enableExtension } from '@/extension'; | ||
import { Component, Vue, Watch } from 'nuxt-property-decorator' | ||
import keyring, { Keyring } from '@polkadot/ui-keyring' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
'Keyring' is defined but never used. @typescript-eslint/no-unused-vars
if (/^5/.test(address)) { | ||
return address | ||
} | ||
|
||
const ss58Format = store.getters.getChainProperties58Format | ||
|
||
return encodeAddress(decodeAddress(address, <any>ss58Format)); | ||
return encodeAddress(decodeAddress(address, <any>ss58Format)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
protected defaultValues: any[] = []; | ||
protected subs: any = {}; | ||
protected keys: any = {} | ||
protected random: any[] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
protected subs: any = {}; | ||
protected keys: any = {} | ||
protected random: any[] = [] | ||
protected defaultValues: any[] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
protected keys: any = {} | ||
protected random: any[] = [] | ||
protected defaultValues: any[] = [] | ||
protected subs: any = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
} | ||
|
||
} | ||
|
||
public beforeDestroy() { | ||
Object.values(this.subs).forEach((sub: any) => sub()); | ||
Object.values(this.subs).forEach((sub: any) => sub()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
const address = typeof account === 'string' ? account : account.address; | ||
const injector = await getAddress(toDefaultAddress(address)); | ||
const hasCallback = typeof statusCb === 'function'; | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[eslint] reported by reviewdog 🐶
Unnecessary try/catch wrapper. no-useless-catch
Thank you for your contribution to the KodaDot NFT gallery.
👇 Do a quick check before the merge.
PR type
Before submitting Pull Request, please make sure:
Optional
What's new?
Had issue bounty label ?
Community participation
Screenshot