Return a Rack::BodyProxy from the Rails::Rack::Logger monkey patch

[ghiculescu]

This should return the same object that Rails is returning. See https://github.com/rails/rails/blob/8d1b8e870c1c42859132c8d51ceff0ac72cbe34b/railties/lib/rails/rack/logger.rb#L38

[iloveitaly]

@ghiculescu could you rebase on master and add an entry to the changelog?

[ghiculescu]

Done, did you also want commits squashed or are you fine to use the github squasher?

[iloveitaly]

@ghiculescu looks like CI is failing, could you take another look?

No worries about squashing—I'll let the GH merge tool handle that.

[sigra]

@iloveitaly @ghiculescu 👋

I'm not sure, but it looks like Rack::BodyProxy#close always calls block in ensure part. But in this PR the block is nil, so I have Read: #<NoMethodError: undefined method :call for nil:NilClass> for each request. It doesn't affect user work, but this spam to stdout doesn't seem right.

Check the original implementation in Rails — https://github.com/rails/rails/blob/v6.1.4.4/railties/lib/rails/rack/logger.rb#L38. They use block.

Also, I checked all gems in my gemset and found out that ALL of them use block.

P.S. I've copied block logic from original Rails implementation and it solves my issue — Salesap@d7ec60e

[iloveitaly]

@sigra interesting! Mind submitting a PR to change our use of BodyProxy?