Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Require active_support before use #340

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 11, 2022

This PR attempts to fix a thing seen in the test output here: https://github.com/roidrage/lograge/runs/4777416627?check_suite_focus=true

This has changed in later releases of ActiveSupport, see this Issue: rails/rails#43851

This has changed in later releases of ActiveSupport, see this Issue: rails/rails#43851
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jan 11, 2022

@iloveitaly This repairs a bunch of issues, and makes the test suite sort of run.

Now, there are failures like:

activesupport-7.1.0.alpha requires ruby version >= 2.7.0, which is incompatible
with the current version, ruby 2.6.8p0 (jruby 9.3.2.0)

Update: Skipped JRuby for Rails 7 in #341

@iloveitaly
Copy link
Collaborator

Awesome! Great changes. Keep them coming :)

@iloveitaly iloveitaly merged commit c46f946 into roidrage:master Jan 11, 2022
@olleolleolle olleolleolle deleted the fix-isol-exec-state branch January 11, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants