Implement new project file name, default.project.json #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoteTheMighty
approved these changes
Feb 1, 2019
server/src/project.rs
Outdated
| warn!("Rename your project file to {}", PROJECT_FILENAME); | ||
| } else if !file_name.ends_with(".project.json") { | ||
| warn!("Starting in Rojo 0.5.0-alpha3, it's recommended to give all project files the"); | ||
| warn!(".project.json extension. This helps Rojo differentiate project file from"); |
There was a problem hiding this comment.
"...helps Rojo differentiate project files from"
|
I think it's okay to keep the plugin place project name relatively unspecific because it's already in the |
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Implement new project file name, default.project.json * Rename all test projects to default.project.json * Update CHANGELOG * Fix warning message typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118.
Changes the default project file name from
roblox-project.jsontodefault.project.json. This opens the door to have other project file names while still allowing Rojo to differentiate project files from random JSON files.Introduces a simple project compatibility mechanism so that the old default project file name (
roblox-project.json) is still supported, but users will be warned to upgrade.