Create a PluginAction for toggling connection #178
Conversation
|
Hey, this fixes #103, too! |
|
Finally getting a chance to look at this! Mechanically, this change looks pretty much perfect. I'm not super sure about the use case for toggling the connection with a hotkey though! What makes you want to do this kind of thing, and is there something else we can fix that might be more direct? |
|
My biggest motivation is the workflow of opening the ribbon bar, clicking the plugin button, then moving the mouse to select the connect button is tedious. I know that yall are looking to have multiple connections tho, so I understand a single "connect" may not be entirely possible anymore. If the plugin had an icon so I could cleanly have it on the quick access bar without having the "Connect" text there, that would help a lot, and could be a nice alternative if you don't want to use plugin actions. |
|
This PR is well over a year old and I don't see this workflow as necessary. Gonna go ahead and close it down so it's not floating around anymore. |
Add's a user-configurable shortcut to start/stop connections to the Rojo server.
Had to hoist up some state from ConnectPanel which I would rather have not done, but not sure if there's a better way without Rodux.