change server bind address #403
Conversation
127.0.0.1 is a loopback interface, and only works on the same host 0.0.0.0 will allow connections from other hosts ideally, this should be a console arg - but it's a quick fix
|
As is, this change is very dangerous! Allowing access for all Rojo connections from outside the current machine opens up a lot of risk for leaking information, or worse, taking advantage of Rojo's two-way sync web API to write files onto the host machine. Instead, I would accept a PR to make this configurable. Having support for |
|
slight nitpick, but contribution page did not mention use of rustfmt - on the other hand, i could have probably been more careful myself |
|
Thanks for putting this together! I pushed a small handful of tweaks to the branch like using I'll land this in the master branch and then backport it so it can be part of a Rojo 6 release, too. |
* web/mod.rs - change server bind address 127.0.0.1 is a loopback interface, and only works on the same host 0.0.0.0 will allow connections from other hosts ideally, this should be a console arg - but it's a quick fix * implement --address option, revert default bind address to 127.0.0.1 * revert silly autoformatting * ok, actually using rustfmt now * More precise --address flag description * Use SocketAddr where available, take advantage of const-ness * Display 'localhost' if address is loopback * Update Changelog Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
* web/mod.rs - change server bind address 127.0.0.1 is a loopback interface, and only works on the same host 0.0.0.0 will allow connections from other hosts ideally, this should be a console arg - but it's a quick fix * implement --address option, revert default bind address to 127.0.0.1 * revert silly autoformatting * ok, actually using rustfmt now * More precise --address flag description * Use SocketAddr where available, take advantage of const-ness * Display 'localhost' if address is loopback * Update Changelog Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
127.0.0.1 is a loopback interface, and only works on the same host
binding to 0.0.0.0 will allow connections from other hosts and will actually give purpose to the IP field on the plugin
i have a laptop running linux (so cannot use studio) and another host running windows, where i RDP to for studio - i was wondering why it couldn't connect. rebuilt with these changes and it can now listen to the linux host
previously:
now:
using stable, but change is universal