Update nil Ref check and property decode warning to new Rojo protocol #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
…rojo-rbx#466) * Skip empty Refs in new Rojo protocol * Update warning message for new Rojo protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had ran into an issue with Refs in #465 on an older version of Rojo, and was guided to try out the latest version and still had issues. These parts of the plugin were relying on the old Rojo protocol and I've now updated them.
Regarding the comment I left on diff.lua#78, I've described one instance that can cause the table to be empty in #467.
The unverified is because my GPG for Windows is kinda messed up. The next commit is verified me!