Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to getProperty for unknown properties. #493

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add a check to getProperty for unknown properties. #493

merged 1 commit into from
Oct 28, 2021

Conversation

GlowingUmbreon
Copy link
Contributor

This commit fixes the issue where the MaterialVariant property of a BasePart would error due to it being a FFlag only feature, and related potential future issues.

Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change, thank you for the PR!

@LPGhatguy LPGhatguy merged commit e136529 into rojo-rbx:master Oct 28, 2021
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants