Add changing toolbar icon to indicate state #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
changed the title
LPGhatguy
approved these changes
Apr 24, 2022
@LPGhatguy Even though those images aren't going to be used in the final result? |
3 tasks
Yup! It's good to have assets available as files in case we need to reupload them for whatever reason. Eventually, maybe we'll use a tool to automatically manage our Roblox assets and keep them in sync with the repo. |
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Add changing toolbar icon * Return to default icon after closing error * Update changelog * Add assets * Improved link icon * Upload new icons Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolbar icon can act as a useful feedback mechanism about session status, especially when the widget is covered/closed.
I've added icon changeability to the StudioToggleButton component, and used it in the App.
The icons added to Assets.lua should preferably be reuploaded by @LPGhatguy for consistency before merging this.