Add notification popups #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider adding a setting so you can still have notifications even if the widget is open! |
sasial-dev
reviewed
May 11, 2022
|
Added setting for notifs, should be nicer to give users that control!
|
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Add notifications prototype * Add timeout * Improve function name * Faster timeouts and fully clickable * Update remove padding from old X button * Only auto-dismiss when viewport is open * Start auto dismiss once viewed * Avoid redundantly displaying widget text as notifs * Add sound effect * Add setting for notifications * Remove duplicate PluginSettings.StudioProvider * Use short pop sound effect * Fix broken audio, thanks Roblox * Use e instead of createElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #537 lands, users will be able to control Rojo without opening the widget or the toolbar. While this is excellent for developer experience, it leads to a total lack of feedback on their actions. As a stopgap, we added logs into the console for them, but that's not a great longterm solution.
I prototyped a notification system that aims to accomplish what @LPGhatguy and I discussed in #537. These show up in the viewport, so even if nothing Rojo-related is open the user will still receive these nice animated and themed popups.
Features:
App:addNotification(text: string, timeout: number?)API so it can be easily integrated throughoutNotifications.mp4