Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to toggle sound effects #568

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Add setting to toggle sound effects #568

merged 2 commits into from
Jul 2, 2022

Conversation

boatbomber
Copy link
Member

Title says it all, really. Adds a playSounds setting and makes the sound player object ingest & respect settings.
image

LPGhatguy
LPGhatguy requested changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! Couple pieces of feedback, then LGTM.

plugin/src/soundPlayer.lua Outdated Show resolved Hide resolved
plugin/src/soundPlayer.lua Outdated Show resolved Hide resolved
@boatbomber boatbomber requested a review from LPGhatguy July 2, 2022 05:52
@LPGhatguy LPGhatguy merged commit 54398d4 into rojo-rbx:master Jul 2, 2022
@boatbomber boatbomber deleted the sound-setting branch July 2, 2022 14:25
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
@boatbomber
Add setting to toggle sound effects (rojo-rbx#568)
849b640 
* Use soundPlayer object with setting

* Style changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPGhatguy LPGhatguy LPGhatguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boatbomber @LPGhatguy