Protect against syncing and building the wrong project types #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
added
type: enhancement
|
You know, that's on me I didn't think to test whether our own tests would break if we changed this, I will fix it soon:tm:. It is currently 80 degrees and my laptop is hot though, so it'll have to wait. |
|
Regarding #691, I think leaving that protection in the plugin is still valuable both as a failsafe and as protection against serves from otherwise compatible <=7.3.0 servers. |
Co-authored-by: Kenneth Loeffler <kenloef@gmail.com>
|
We can revisit tests later, since I'm not sure on the names of some of these. I want to keep the diff as relevant as possible though, since this turned into a bigger patch than anticipated. |
Dekkonot
requested review from
kennethloeffler and
boatbomber
and removed request for
kennethloeffler
|
..Apologies for whatever the hell notification that just sent you, Ken. Github's UI isn't intuitive for this. |
boatbomber
approved these changes
Aug 21, 2023
Dekkonot
requested review from
kennethloeffler
and removed request for
kennethloeffler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #736.
Prevents projects with a data model as a root from being built as a model file and vice versa. Also prevents syncing model files altogether.
This should mitigate a few of the more common problems with building Rojo projects. I'm not sure whether I should revert #691 or not. The check it adds is made moot with this PR, but it could be a good failsafe. Open to suggestion.
This doesn't impact the VSCode extension at all because it determines the file type to build as using a similar heuristic as this PR and listens to errors during serving to display to the user.