Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a patch fails, import the Instance directly using GetObjects #786

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

When a patch fails, import the Instance directly using GetObjects #786

wants to merge 34 commits into from

Commits on Aug 27, 2023

  1. Pass ServeSession to reify

    @Dekkonot
    Dekkonot committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    a67aec4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Use tempfile as a normal dependency

    @Dekkonot
    Dekkonot committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0017861 View commit details
    Browse the repository at this point in the history

  2. Store a lazy ref to a temp dir in ServeSession

    @Dekkonot
    Dekkonot committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    70b1899 View commit details
    Browse the repository at this point in the history

  3. Initial implementation of fetch endpoint

    @Dekkonot
    Dekkonot committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ef90926 View commit details
    Browse the repository at this point in the history

  4. Add initial implementation of fetch api for client

    @Dekkonot
    Dekkonot committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a5af0e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Don't actually pass ServeSession to reify 

    this was widely regarded as a bad move
    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    7145d70 View commit details
    Browse the repository at this point in the history

  2. Pass apiContext to reconciler and applyPatch

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f2cdcae View commit details
    Browse the repository at this point in the history

  3. Make fetchInstances its own module

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    24ce366 View commit details
    Browse the repository at this point in the history

  4. Initial implementation of fetchApi in applyPatch

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    de3c15b View commit details
    Browse the repository at this point in the history

  5. Use a folder in the content directory 

    As opposed to a temp dir and hardlinks
    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9c3d84e View commit details
    Browse the repository at this point in the history

  6. Move tempfile back to dev dependencies

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    c69ebbe View commit details
    Browse the repository at this point in the history

  7. Handle an invalid request better

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2abac70 View commit details
    Browse the repository at this point in the history

  8. Rename fetch dir constant

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    e057711 View commit details
    Browse the repository at this point in the history

  9. Actually remove the old copy of fetchInstances from reify

    @Dekkonot
    Dekkonot committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    04b3479 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Account for classes with specific parent needs

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    af7e372 View commit details
    Browse the repository at this point in the history

  2. Add explanatory comment

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b8829a0 View commit details
    Browse the repository at this point in the history

  3. Change how fetchInstances checks invariants

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e778863 View commit details
    Browse the repository at this point in the history

  4. Change debug for swapping instances to trace

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    190d458 View commit details
    Browse the repository at this point in the history

  5. Use request body instead of URL for fetch endpoint

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    47dbf1b View commit details
    Browse the repository at this point in the history

  6. Remove unhelpful debug log

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d77e5f2 View commit details
    Browse the repository at this point in the history

  7. Reference instances by key instead of name

    @Dekkonot
    Dekkonot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e0c4380 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Don't clone subtree when building fetch model

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d905679 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fetch-bad-patch

    @Dekkonot
    Dekkonot authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    08fd714 View commit details
    Browse the repository at this point in the history

  3. StyLua

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e721e6e View commit details
    Browse the repository at this point in the history

  4. Preserve selection when replacing instances

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2c02328 View commit details
    Browse the repository at this point in the history

  5. Cleanup fetch endpoint

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6d6e0fe View commit details
    Browse the repository at this point in the history

  6. Remove unused imports in Reify

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6666e11 View commit details
    Browse the repository at this point in the history

  7. Remove extra argument to applyPatch in ServeSession

    @Dekkonot
    Dekkonot committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d7ace0f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Create .git-blame-ignore-revs & Add Stylua pr (rojo-rbx#787) 

    adds stylua pr to ignore so it doesn't show on git blame history
    @Barocena @Dekkonot
    Barocena authored and Dekkonot committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    94cf688 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Add setting to turn functionality off

    @Dekkonot
    Dekkonot committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    385340f View commit details
    Browse the repository at this point in the history

  2. Lock fetchOnPatchFail setting while sync is active

    @Dekkonot
    Dekkonot committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    81a5c0f View commit details
    Browse the repository at this point in the history

  3. Move ChangeHistoryService waypoint creation to Reconciler

    @Dekkonot
    Dekkonot committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    424b1d0 View commit details
    Browse the repository at this point in the history

  4. Move fetchinstances call to reconciler

    @Dekkonot
    Dekkonot committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a5321be View commit details
    Browse the repository at this point in the history

  5. Respect setting for fetch usage in reconciler

    @Dekkonot
    Dekkonot committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d21ffe1 View commit details
    Browse the repository at this point in the history