Skip to content

Commit

Permalink
Add status info to docs
Browse files Browse the repository at this point in the history
  • Loading branch information
rok committed Aug 21, 2024
1 parent 1f55e2f commit 1daadfe
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 11 deletions.
3 changes: 1 addition & 2 deletions cpp/src/arrow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ set(ARROW_SRCS
datum.cc
device.cc
extension_type.cc
extension/bool8.cc
extension/uuid.cc
pretty_print.cc
record_batch.cc
Expand Down Expand Up @@ -907,10 +908,8 @@ endif()

if(ARROW_JSON)
arrow_add_object_library(ARROW_JSON
extension/bool8.cc
extension/fixed_shape_tensor.cc
extension/opaque.cc
extension/uuid_array.cc
json/options.cc
json/chunked_builder.cc
json/chunker.cc
Expand Down
5 changes: 1 addition & 4 deletions cpp/src/arrow/extension/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.

set(CANONICAL_EXTENSION_TESTS uuid_test.cc)
set(CANONICAL_EXTENSION_TESTS bool8_test.cc opaque_test.cc uuid_test.cc)

if(ARROW_JSON)
list(APPEND CANONICAL_EXTENSION_TESTS fixed_shape_tensor_test.cc)
Expand All @@ -24,9 +24,6 @@ endif()
add_arrow_test(test
SOURCES
${CANONICAL_EXTENSION_TESTS}
bool8_test.cc
opaque_test.cc
uuid_test.cc
PREFIX
"arrow-canonical-extensions")

Expand Down
5 changes: 2 additions & 3 deletions cpp/src/arrow/extension_type.cc
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,10 @@ static void CreateGlobalRegistry() {
g_registry = std::make_shared<ExtensionTypeRegistryImpl>();

#ifdef ARROW_JSON
std::vector<std::shared_ptr<DataType>> ext_types{extension::bool8(), ::arrow::extension::uuid()};
std::vector<std::shared_ptr<DataType>> ext_types{extension::bool8(), extension::uuid()};
#else
std::vector<std::shared_ptr<DataType>> ext_types{
extension::bool8(), ::arrow::extension::uuid()};
std::vector<std::shared_ptr<DataType>> ext_types{::arrow::extension::uuid()};
extension::bool8(), extension::fixed_shape_tensor(int64(), {}), extension::uuid()};
#endif

// Register canonical extension types
Expand Down
2 changes: 2 additions & 0 deletions docs/source/format/CanonicalExtensions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ JSON
In the future, additional fields may be added, but they are not required
to interpret the array.

.. _uuid_extension:

UUID
====

Expand Down
2 changes: 2 additions & 0 deletions docs/source/status.rst
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ Data Types
+-----------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| Variable shape tensor | | | | | | | | |
+-----------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| UUID || | | | | | | |
+-----------------------+-------+-------+-------+------------+-------+-------+-------+-------+

Notes:

Expand Down
4 changes: 2 additions & 2 deletions python/pyarrow/tests/test_extension_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def test_ext_type__storage_type():

def test_ext_type_byte_width():
# Test for fixed-size binary types
ty = UuidType()
ty = pa.UuidType()
assert ty.byte_width == 16
ty = ParamExtType(5)
assert ty.byte_width == 5
Expand All @@ -300,7 +300,7 @@ def test_ext_type_byte_width():

def test_ext_type_bit_width():
# Test for fixed-size binary types
ty = UuidType()
ty = pa.UuidType()
assert ty.bit_width == 128
ty = ParamExtType(5)
assert ty.bit_width == 40
Expand Down

0 comments on commit 1daadfe

Please sign in to comment.