Review feedback

rok · Dec 11, 2023 · 50dc6a4 · 50dc6a4
1 parent 8ad357a
commit 50dc6a4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/cpp/src/arrow/acero/util_test.cc b/cpp/src/arrow/acero/util_test.cc
@@ -17,7 +17,6 @@
 
 #include "arrow/acero/hash_join_node.h"
 #include "arrow/acero/schema_util.h"
-#include "arrow/testing/extension_type.h"
 #include "arrow/testing/gtest_util.h"
 #include "arrow/testing/matchers.h"
 

diff --git a/cpp/src/arrow/c/bridge_test.cc b/cpp/src/arrow/c/bridge_test.cc
@@ -2160,10 +2160,15 @@ TEST_F(TestSchemaImport, RunEndEncoded) {
 #endif
 
 TEST_F(TestSchemaImport, Dictionary) {
+  FillPrimitive("w:16");
+  c_struct_.metadata = kEncodedUuidMetadata.c_str();
+  auto expected = uuid();
+  CheckImport(expected);
+
   FillPrimitive(AddChild(), "u");
   FillPrimitive("c");
   FillDictionary();
-  auto expected = dictionary(int8(), utf8());
+  expected = dictionary(int8(), utf8());
   CheckImport(expected);
 
   FillPrimitive(AddChild(), "u");
@@ -3695,6 +3700,7 @@ TEST_F(TestSchemaRoundtrip, Dictionary) {
 }
 
 TEST_F(TestSchemaRoundtrip, UnregisteredExtension) {
+  TestWithTypeFactory(uuid, []() { return uuid(); });
   TestWithTypeFactory(complex128, []() {
     return struct_({::arrow::field("real", float64(), /*nullable=*/false),
                     ::arrow::field("imag", float64(), /*nullable=*/false)});

diff --git a/python/pyarrow/src/arrow/python/gdb.cc b/python/pyarrow/src/arrow/python/gdb.cc
@@ -76,7 +76,7 @@ class UuidType : public ExtensionType {
     return Status::NotImplemented("");
   }
 
-  std::string Serialize() const override { return "uuid-serialized"; }
+  std::string Serialize() const override { return ""; }
 };
 
 std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,