MINOR: [PYTHON] Add ty as a step in the action
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main problem was that these were annotated as instance methods rather than static/class methods, but I've added some detail, too.
Fix stubs for Table factory methods
chore: update pre-commit
fix: make fs.FileSystem.from_uri and hdfs.HadoopFileSystem.from_uri as classmethod
Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com>
This reverts commit 7ee3d2f.
rok
added a commit
that referenced
this pull request
Jul 24, 2025
* Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" * update ty config --------- Co-authored-by: Rok Mihevc <rok@mihevc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need some kind of type checking in CI, so users know if they have broke anything.
What changes are included in this PR?
Adds a single step in the Python workflow to run
ty check. Ideally, we'd use a GitHub Action ifastralrelease one. It would be nice also if this were an extra job (usingneeds: docker), and copy over the artefacts. But I wasn't sure what to copy over, so playing it safe.Are these changes tested?
It will once the actions here run.
Are there any user-facing changes?
No.