Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript compilation failures #45

Closed
medington opened this issue Jul 21, 2018 · 1 comment · Fixed by #47
Closed

Typescript compilation failures #45

medington opened this issue Jul 21, 2018 · 1 comment · Fixed by #47

Comments

@medington
Copy link

After cloning the repo at the current master, I'm seeing the following compilation issues:

node_modules/redux-devtools-extension/index.d.ts:1:32 - error TS2305: Module '"/data/tmp/redux-async-ts/node_modules/redux/index"' has no exported member 'GenericStoreEnhancer'.

1 import {Action, ActionCreator, GenericStoreEnhancer, compose} from "redux";
                                 ~~~~~~~~~~~~~~~~~~~~
types/global.d.ts:11:48 - error TS2344: Type 'keyof T' does not satisfy the constraint 'string'.
  Type 'string | number | symbol' is not assignable to type 'string'.
    Type 'number' is not assignable to type 'string'.

11 type Omit<T, K extends keyof T> = { [P in Diff<keyof T, K>]: T[P] };
                                                  ~~~~~~~

Steps:

  • Clone this repo
  • npm install
  • npx tsc

The second error appears to be related to known breaking changes in Typescript 2.9 with keyof. I'm assuming the first issue is just an out of sync typing file.

Downgrading to Typescript 2.8.4 got rid of the second issue.

@medington
Copy link
Author

medington commented Jul 21, 2018

PR #46 submitted. I disabled the new keyOf behavior in tsconfig.ts and upgraded redux-devtools-extension to fix the issue mentioned here: zalmoxisus/redux-devtools-extension#492.

rokoroku added a commit that referenced this issue Jul 22, 2018
Fix Typescript compilation issue #45
rokoroku added a commit that referenced this issue Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant