-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Diagnostic Filters and adds human-readable diagnostic names #1241
base: release-1.0.0
Are you sure you want to change the base?
Conversation
@josephjunker Please take a look at this PR -- you did a lot of work on DiagnosticFiltering and I hope that's respected here. |
@markwpearce Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did an initial pass of this and have some suggestions. I still need to go through every diagnostic code and tweak their names, that'll come later.
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've only made it through diagnostic code 1063. Figure I'll submit what I have awhile, and keep working.
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some more name tweaks.
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Addresses #1060
bsconfig.json
"diagnosticFilters"
option to look like this:In more detail:
Additionally, I went through all the diagnostics and assigned a human-readable
code
property to them, which can also be used for any diagnostic filtering. The previous (numerical) code property was renamed tolegacyCode