added controls to display, select, add, and remove automation configs #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bronley Plumb <bronley@gmail.com>
autorun management functions in a dialog. Functions include adding, copying, removing, and managing order of autoruns.
(includes a column of button actions), also no commit style semantics
also graceful exit when run execution fails (for example when rta is confused by disabled app/channel)
Comment on lines
8
to
13
| let runTable; | ||
| let runNameInput; | ||
| let runNameDialog; | ||
| let runNameDialogValue; | ||
| let confirmDialog; | ||
| let showContent = false; |
There was a problem hiding this comment.
Let's ensure that all variables in this file have a typescript type assigned.
| let confirmDialog; | ||
| let showContent = false; | ||
|
|
||
| const toggleDropDown = () => { |
There was a problem hiding this comment.
Let's convert all of these to normal named functions. I.e.
function toggleDropdown() {
....
| } | ||
| }; | ||
|
|
||
| const copyRun = (e) => { |
There was a problem hiding this comment.
Convert this to an async function that leverages await instead of using promises. (code is cleaner that way)
Comment on lines
53
to
75
| new Promise((resolve, reject) => { | ||
| let confirmDialogCallback; | ||
| confirmDialog.addEventListener( | ||
| 'click', | ||
| (confirmDialogCallback = (e) => { | ||
| const button = e?.target?.id; | ||
| if (button === 'YES') { | ||
| resolve(); | ||
| } else if (button === 'NO') { | ||
| reject(); | ||
| } else { | ||
| return; | ||
| } | ||
| e.stopPropagation(); | ||
| confirmDialog.removeEventListener( | ||
| 'click', | ||
| confirmDialogCallback | ||
| ); | ||
| confirmDialog.close(); | ||
| }) | ||
| ); | ||
| confirmDialog.showModal(); | ||
| }) |
There was a problem hiding this comment.
Let's move most of this to native svelte actions on the confirm dialog itself. You can store the selected run for use in that separate function
also added an alert dialog, shown when user input (for run name) is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.