Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage #109

Merged
merged 148 commits into from
Jun 2, 2020
Merged

Improve code coverage #109

merged 148 commits into from
Jun 2, 2020

Conversation

rokumatsumoto
Copy link
Owner

@rokumatsumoto rokumatsumoto commented Jun 2, 2020 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Bug Fix
  • Optimization

Description

This PR mainly focused on Rails Active Record models. Additionally, it contains some Service Objects. I understand and agree with the Create small PRs rule. For the next time, this will be exemplary to me.

During the process of improving code coverage, code has been carefully refactored and reviewed. As a result of that, code coverage for Rails Active Record models increased dramatically.

Models code coverage:

Models (97.24% covered at 37.82 hits/line)
21 files in total. 362 relevant lines. 352 lines covered and 10 lines missed

Overall code coverage:

All Files (47.39% covered at 11.0 hits/line)
130 files in total. 2433 relevant lines. 1153 lines covered and 1280 lines missed

I'm working on improving code coverage for Service Objects.

Other improvements

  • Configure Reek for code smells
  • Make the cops happy
  • Remove unused files and code blocks
  • Improve readability of code blocks
  • Use modules for common functionality

Related Tickets & Documents

Upgrade to Rails 6

Added tests?

  • yes

@rokumatsumoto
Refactor authorization policies
2de4f54
@rokumatsumoto
Refactor authorization policy tests
4241169
@rokumatsumoto
Add test for User policy
2878acb
@rokumatsumoto
Add shared example for generating new friendly_id
a641fbe
@rokumatsumoto
Update Category factory
a4f4730
@rokumatsumoto
Refactor Category model
03f49fd
@rokumatsumoto
Refactor Design model tests
21fc20b
@rokumatsumoto
Add tests for Category model
a96baf1
@rokumatsumoto
Add Javascript compatible email regex for Devise scopes
b06fdc1
@rokumatsumoto
Refactor Category model tests
2143629
@rokumatsumoto
Refactor Design model tests
d4361e3
@rokumatsumoto
Rename email format shared examples
8c360d4
@rokumatsumoto
Refactor UrlBuilder class
2aadab5
@rokumatsumoto
Refactor FilenameHelpers class
4661f75
@rokumatsumoto
Refactor User model
0098bad
@rokumatsumoto
Add tests for User model
89fa32d
@rokumatsumoto
Add tests for Users controller
55a902e
@rokumatsumoto
Refactor User model
88cceee
@rokumatsumoto
Add tests for User model
0ed5bc2
@rokumatsumoto
Add tests for User model
a56e73f
@rokumatsumoto
Add tests for Users update service
62105de
@rokumatsumoto
Update Identity factory
1cedfa5
@rokumatsumoto
Update User factory
5de8b0e
@rokumatsumoto
Update Identity model
9ab02c9
@rokumatsumoto
Update i18n translations for Identity model
3aa9b4e
@rokumatsumoto
Add tests for Identity model
55af7e6
@rokumatsumoto
Refactor Blueprint model
ca3a1ed
@rokumatsumoto
Update FileValidations module
17b3cda
@rokumatsumoto
Update i18n translations for Blueprint model
b7a1d13
@rokumatsumoto
Add tests for Blueprint model
b8673c9
@rokumatsumoto
Update description of a spec
3efa793
@rokumatsumoto
Update Designs::BaseService
61f23d6 
- Change method access control from protected to private
- Remove Boyutluseyler::Utils::StrongMemoize mixin
@rokumatsumoto
Refactor method calls to make the logic more self-explanatory
b53dcb3 
- Change method access control from public to private except execute method
@rokumatsumoto
Specify default bucket in the constructor
dc5e8f5
@rokumatsumoto
Add getter for bucket
77ca26d
@rokumatsumoto
Change type of PathHelper from class to module
a233933
@rokumatsumoto
Add MimeUtil module
ca88180
@rokumatsumoto
Add FileFormat module
7d4fc66
@rokumatsumoto
Add CollectionIdListHelper module
e4ab288
@rokumatsumoto
Refactor design creation process
e3f9c1c 
- Add Designs::AfterCreateService class
- Move before_create code block into Designs::BuildService class
- Refactor Designs::BaseService class
@rokumatsumoto
Create design download with not_ready step
cc9c1e2
@rokumatsumoto
Refactor design update process
66ddf3c 
- Add Designs::BeforeUpdateService class
- Move after_update code block into Designs::BeforeUpdateService class
@rokumatsumoto
Refactor Designs::Files::MoveService class
f409546
@rokumatsumoto
Refactor Designs::Files::ListService class
2502706
@rokumatsumoto
Refactor AvailableDownloadBroadcastWorker class
3f4c895 
Improve readability
@rokumatsumoto
Refactor Designs::Downloads::StateMachineService class
1c74452
@rokumatsumoto
Add shared context for design create process
dd666e9
@rokumatsumoto
Add tests for Designs::BuildService
4166d49
@rokumatsumoto
Add tests for Designs::CreateService
c968bc5
@rokumatsumoto
Configure SimpleCov for Rails
026677d
@rokumatsumoto
Make the cops happy
601cd75
@rokumatsumoto
Fix advisories after having a reasonable code coverage
48604df
@rokumatsumoto rokumatsumoto added the backstage Issues and merge request related to improvements like refactorings, tests, maintenance etc label Jun 2, 2020
@rokumatsumoto rokumatsumoto added this to the 0.12.1 milestone Jun 2, 2020
@rokumatsumoto rokumatsumoto self-assigned this Jun 2, 2020
@rokumatsumoto rokumatsumoto marked this pull request as ready for review June 2, 2020 17:28
@rokumatsumoto rokumatsumoto added staging Merge request has been deployed to staging environment staging succeed and removed staging Merge request has been deployed to staging environment labels Jun 2, 2020
@rokumatsumoto rokumatsumoto merged commit f00ddbd into master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rokumatsumoto rokumatsumoto

Labels
backstage Issues and merge request related to improvements like refactorings, tests, maintenance etc staging succeed
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
1 participant
@rokumatsumoto