fix: filter import errors and close TypeStrong#653

rolandjitsu · Oct 8, 2018 · 79d9c91 · 79d9c91
1 parent 5490e9d
commit 79d9c91
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -20,6 +20,7 @@ import {
   formatErrors,
   getAndCacheOutputJSFileName,
   getAndCacheProjectReference,
+  noImportError,
   validateSourceMapOncePerProject
 } from './utils';
 
@@ -475,7 +476,7 @@ function getTranspilationEmit(
       loaderContext.context
     );
 
-    loaderContext._module.errors.push(...errors);
+    loaderContext._module.errors.push(...errors.filter(noImportError));
   }
 
   return { outputText, sourceMapText };

diff --git a/src/instances.ts b/src/instances.ts
@@ -22,7 +22,8 @@ import {
   ensureProgram,
   formatErrors,
   isUsingProjectReferences,
-  makeError
+  makeError,
+  noImportError
 } from './utils';
 import { makeWatchRun } from './watch-run';
 
@@ -111,7 +112,7 @@ function successfulTypeScriptInstance(
       loader.context
     );
 
-    loader._module.errors.push(...errors);
+    loader._module.errors.push(...errors.filter(noImportError));
 
     return {
       error: makeError(
@@ -176,7 +177,7 @@ function successfulTypeScriptInstance(
         loader.context
       );
 
-      loader._module.errors.push(...errors);
+      loader._module.errors.push(...errors.filter(noImportError));
     }
 
     instances[loaderOptions.instance] = {

diff --git a/src/utils.ts b/src/utils.ts
@@ -268,6 +268,13 @@ export function isUsingProjectReferences(instance: TSInstance) {
   return false;
 }
 
+export function noImportError(error: WebpackError) {
+  const { message } = error;
+  const v3 = /export '.*'( \(reexported as '.*'\))? was not found in/;
+  const v4 = /Attempted import error: '.*' is not exported from '.*'\./;
+  return v3.test(message) || v4.test(message);
+}
+
 /**
  * Gets the project reference for a file from the cache if it exists,
  * or gets it from TypeScript and caches it otherwise.