Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default user and org visibility #124

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

abrain
Copy link
Contributor

@abrain abrain commented Sep 15, 2023

The new variables DEFAULT_USER_VISIBILITY and DEFAULT_ORG_VISIBILITY always were set to true because of a ternary filter.

@DO1JLR
Copy link
Member

DO1JLR commented Oct 10, 2023

based on the docs to tenary, it should work:
https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_filters.html#defining-different-values-for-true-false-null-ternary

Are you sure, the tenary filter is not working @abrain ?

@abrain
Copy link
Contributor Author

abrain commented Oct 10, 2023

The ternary filter was working fine. The issue is rather that the variables DEFAULT_USER_VISIBILITY and DEFAULT_ORG_VISIBILITY aren't booleans but values like public or private and shouldn't have a ternary filter applied to them.

@DO1JLR
Copy link
Member

DO1JLR commented Oct 10, 2023

ah, good point. thanks.

@DO1JLR DO1JLR merged commit ec13147 into roles-ansible:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants