fix: Connection.encode complains when value is an object having unico…

…de characters in its printable representation
rolette · May 4, 2015 · 19d48d8 · 19d48d8
1 parent bc61eb9
commit 19d48d8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/redis/connection.py b/redis/connection.py
@@ -588,7 +588,7 @@ def encode(self, value):
         elif isinstance(value, float):
             value = b(repr(value))
         elif not isinstance(value, basestring):
-            value = str(value)
+            value = unicode(value)
         if isinstance(value, unicode):
             value = value.encode(self.encoding, self.encoding_errors)
         return value

diff --git a/tests/test_encoding.py b/tests/test_encoding.py
@@ -23,6 +23,13 @@ def test_list_encoding(self, r):
         r.rpush('a', *result)
         assert r.lrange('a', 0, -1) == result
 
+    def test_object_value(self, r):
+        unicode_string = unichr(3456) + u('abcd') + unichr(3421)
+        r['unicode-string'] = Exception(unicode_string)
+        cached_val = r['unicode-string']
+        assert isinstance(cached_val, unicode)
+        assert unicode_string == cached_val
+
 
 class TestCommandsAndTokensArentEncoded(object):
     @pytest.fixture()