improve object handling #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezarowny
force-pushed
the
improve-object-handling
branch
from
9954c6b
to
d9aae20
Compare
|
@coryvirok thoughts? |
ezarowny
force-pushed
the
improve-object-handling
branch
from
d9aae20
to
13488b2
Compare
ezarowny
force-pushed
the
improve-object-handling
branch
from
13488b2
to
0eadc09
Compare
|
LGTM |
| return handler(obj, key=key) | ||
| except: | ||
| # use the default handler for unknown object types | ||
| log.exception("Exception while processing Rollbar Item. " |
There was a problem hiding this comment.
This error message doesn't seem very informative... if I see this in my logs, I don't know if it's a problem or not, what I should do, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects that appear to be a namedtuple, like SQLAlchemy's NamedTuple and KeyedTuple, could cause Exceptions while identifying them if they don't implement the
_makemethod.Addresses #103.