Don't skip delayed_job reports if threshold is 0

lib/rollbar/delayed_job.rb

@@ -56,13 +56,19 @@ def self.invoke_job_callback
     end
 
     def self.report(e, job)
-      return unless job.attempts <= ::Rollbar.configuration.dj_threshold
+      return if skip_report?(job)
 
       data = build_job_data(job)
 
       ::Rollbar.scope(:request => data).error(e, :use_exception_level_filters => true)
     end
 
+    def self.skip_report?(job)
+      threshold = ::Rollbar.configuration.dj_threshold
+
+      !threshold.zero? && job.attempts > threshold
+    end
+
     def self.build_job_data(job)
       return nil unless ::Rollbar.configuration.report_dj_data
 

spec/rollbar/delayed_job_spec.rb

@@ -58,4 +58,44 @@ def do_job_please!(a, b)
       end
     end
   end
+
+  describe '.skip_report' do
+    let(:configuration) { Rollbar.configuration }
+
+    before do
+      allow(configuration).to receive(:dj_threshold).and_return(5)
+    end
+
+    context 'configuration.dj_threshold = 0' do
+      let(:job) { double(attempts: 6) }
+
+      it 'returns false' do
+        expect(described_class.skip_report?(job)).to be(true)
+      end
+    end
+
+    context 'with attempts > configuration.dj_threshold' do
+      let(:job) { double(attempts: 6) }
+
+      it 'returns true' do
+        expect(described_class.skip_report?(job)).to be(true)
+      end
+    end
+
+    context 'with attempts < configuration.dj_threshold' do
+      let(:job) { double(attempts: 3) }
+
+      it 'returns false' do
+        expect(described_class.skip_report?(job)).to be(false)
+      end
+    end
+
+    context 'with attempts == configuration.dj_threshold' do
+      let(:job) { double(attempts: 4) }
+
+      it 'returns false' do
+        expect(described_class.skip_report?(job)).to be(false)
+      end
+    end
+  end
 end