Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report_validation_errors_to_rollbar should be mixed into ActiveModel, not ActiveRecord #248

Closed
rmm5t opened this issue May 28, 2015 · 2 comments
Closed

report_validation_errors_to_rollbar should be mixed into ActiveModel, not ActiveRecord #248

rmm5t opened this issue May 28, 2015 · 2 comments

Comments

@rmm5t
Copy link

rmm5t commented May 28, 2015

Currently, report_validation_errors_to_rollbar is mixed into ActiveRecord only. Instead, it should be mixed into ActiveModel, since validations are tied directly to ActiveModel, and this would allow validation reporting to other ActiveModel compatible ORM/ODMs like Mongoid, etc.
@jondeandres
Copy link
Contributor

Good point @rmm5t, we'll fix this soon.

Thanks!

@rassom rassom mentioned this issue Jul 20, 2016
Closed
@jondeandres
Copy link
Contributor

This is fixed in #503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmm5t @jondeandres