Include validations plugin in activerecord base #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case `ActiveRecord::Base` has been already loaded before our validations plugin is loading, `ActiveRecord::Base` will already include ActiveModel::Validations but will not have our validations method. We want in this case to include it also in `ActiveRecord::Base` so it can be used by the customers without `NoMethodError` exceptions
jondeandres
deleted the
include-validations-plugin-in-activerecord-base
branch
jondeandres
added a commit
that referenced
this pull request
Sep 15, 2016
Features: - Allow to override config. See [#519](#519). - Send code and context frame data. See [#523](#523). - Send GET, POST and raw body in their correct place. See [#522](#522). - Increase max payload from 128kb to 512kb. See [#521](#521). - Add resque-rollbar functionality to the gem. See [#516](#516). - Send custom.orig_host and custom.orig_uuid on too large payloads. See [#518](#518). - Add Content-Length and Content-Type headers to the reports. See [#513](#513). Bug fixes: - SecureHeaders fixes. See [#478](#478). - Include validations plugin in activerecord base. See [#503](#503). - Require tempfile and use ::Tempfile. See [#514](#514). - Extract correct client IP from X-Forwarded-For header. See [#515](#515). - Delayed job fix on job serialization. See [#512](#512). Others: - Fix tests on rails40 and ruby 1.8.7. See [#485](#485). - Move log methods to public section. See [#498](#498). - Change rails50.gemfile to use Rails 5.0.0. See [#495](#495). - Update CHANGELOG.md to fix incorrect links. See [#502](#502). - Improve Rake support to avoid conflicts with other services. See [#517](#517). - Make Codeclimate happier with Rollbar::Middlware::Js. See [#520](#520).
Merged
jondeandres
added a commit
that referenced
this pull request
Sep 15, 2016
[skip ci] Features: - Allow to override config. See [#519](#519). - Send code and context frame data. See [#523](#523). - Send GET, POST and raw body in their correct place. See [#522](#522). - Increase max payload from 128kb to 512kb. See [#521](#521). - Add resque-rollbar functionality to the gem. See [#516](#516). - Send custom.orig_host and custom.orig_uuid on too large payloads. See [#518](#518). - Add Content-Length and Content-Type headers to the reports. See [#513](#513). Bug fixes: - SecureHeaders fixes. See [#478](#478). - Include validations plugin in activerecord base. See [#503](#503). - Require tempfile and use ::Tempfile. See [#514](#514). - Extract correct client IP from X-Forwarded-For header. See [#515](#515). - Delayed job fix on job serialization. See [#512](#512). Others: - Fix tests on rails40 and ruby 1.8.7. See [#485](#485). - Move log methods to public section. See [#498](#498). - Change rails50.gemfile to use Rails 5.0.0. See [#495](#495). - Update CHANGELOG.md to fix incorrect links. See [#502](#502). - Improve Rake support to avoid conflicts with other services. See [#517](#517). - Make Codeclimate happier with Rollbar::Middlware::Js. See [#520](#520).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
ActiveRecord::Basehas been already loaded before ourvalidations plugin is loading,
ActiveRecord::Basewill already includeActiveModel::Validations but will not have our validations method.
We want in this case to include it also in
ActiveRecord::Baseso it canbe used by the customers without
NoMethodErrorexceptions