Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed job fix on job serialization #512

Merged
merged 3 commits into from
Sep 1, 2016

Conversation

jondeandres
Copy link
Contributor

No description provided.

  instead call #to_hash, and turn all the keys to strings, to
  keep the rest of the implementation untouched
@jondeandres jondeandres changed the title Delayed job fix Delayed job fix on job serialization Aug 31, 2016
- Add correct namespace to JobData class
- Rename job_data.rb spec to job_data_spec.rb
- Detect when the job.payload_object respond to :object or not

Closes #473
@jondeandres jondeandres force-pushed the jon/delayed-job-sequel-as-json-error branch from 5037940 to d671767 Compare August 31, 2016 15:47
@jondeandres jondeandres merged commit 8284246 into master Sep 1, 2016
@jondeandres jondeandres deleted the jon/delayed-job-sequel-as-json-error branch September 1, 2016 17:04
jondeandres added a commit that referenced this pull request Sep 15, 2016
Features:
- Allow to override config. See [#519](#519).
- Send code and context frame data. See [#523](#523).
- Send GET, POST and raw body in their correct place. See [#522](#522).
- Increase max payload from 128kb to 512kb. See [#521](#521).
- Add resque-rollbar functionality to the gem. See [#516](#516).
- Send custom.orig_host and custom.orig_uuid on too large payloads. See [#518](#518).
- Add Content-Length and Content-Type headers to the reports. See [#513](#513).

Bug fixes:
- SecureHeaders fixes. See [#478](#478).
- Include validations plugin in activerecord base. See [#503](#503).
- Require tempfile and use ::Tempfile. See [#514](#514).
- Extract correct client IP from X-Forwarded-For header. See [#515](#515).
- Delayed job fix on job serialization. See [#512](#512).

Others:
- Fix tests on rails40 and ruby 1.8.7. See [#485](#485).
- Move log methods to public section. See [#498](#498).
- Change rails50.gemfile to use Rails 5.0.0. See [#495](#495).
- Update CHANGELOG.md to fix incorrect links. See [#502](#502).
- Improve Rake support to avoid conflicts with other services. See [#517](#517).
- Make Codeclimate happier with Rollbar::Middlware::Js. See [#520](#520).
@jondeandres jondeandres mentioned this pull request Sep 15, 2016
jondeandres added a commit that referenced this pull request Sep 15, 2016
[skip ci]

Features:
- Allow to override config. See [#519](#519).
- Send code and context frame data. See [#523](#523).
- Send GET, POST and raw body in their correct place. See [#522](#522).
- Increase max payload from 128kb to 512kb. See [#521](#521).
- Add resque-rollbar functionality to the gem. See [#516](#516).
- Send custom.orig_host and custom.orig_uuid on too large payloads. See [#518](#518).
- Add Content-Length and Content-Type headers to the reports. See [#513](#513).

Bug fixes:
- SecureHeaders fixes. See [#478](#478).
- Include validations plugin in activerecord base. See [#503](#503).
- Require tempfile and use ::Tempfile. See [#514](#514).
- Extract correct client IP from X-Forwarded-For header. See [#515](#515).
- Delayed job fix on job serialization. See [#512](#512).

Others:
- Fix tests on rails40 and ruby 1.8.7. See [#485](#485).
- Move log methods to public section. See [#498](#498).
- Change rails50.gemfile to use Rails 5.0.0. See [#495](#495).
- Update CHANGELOG.md to fix incorrect links. See [#502](#502).
- Improve Rake support to avoid conflicts with other services. See [#517](#517).
- Make Codeclimate happier with Rollbar::Middlware::Js. See [#520](#520).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants