Support nested exceptions for Ruby 2.1. Fixes #118. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I spent a little time thinking about the order of the exceptions in the trace_chain, but I think you have it right here. |
brianr
added a commit
that referenced
this pull request
Sep 30, 2014
Support nested exceptions for Ruby 2.1. Fixes #118.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for nested exceptions, which where added in Ruby 2.1.
The code checks if the reported exception responds to the
#causemethod and then loops over the cause exceptions generating an array of traces.If the number of traces is 1, we send the payload using
traceand we usetrace_chainif the number of traces is more than 1.