Allow config to not inject the exception hooks #169
Conversation
helpful if you want to add the rollbar middleware yourself
|
Thanks for the PR! Looks good to me. @jondeandres can you take a look as well? |
| @@ -86,6 +88,10 @@ def initialize_copy(orig) | |||
| end | |||
| end | |||
|
|
|||
| def do_not_inject_exception_hook | |||
There was a problem hiding this comment.
Do you have a use case for this method? It's, at least, not used in the PR.
|
@pedro it's nice ;-), just added some comments. this should still be used with caution, cause we don't have standalone middleware for builder, just sinatra apps. we'll add it soon. Thanks for the PR! |
|
Good call on the name change, updated it. Also took a stab updating the readme to explain this. Documentation is of course more personal/harder to change so feel free to edit the changes yourself, discard them or whatever :} My use case is explained here: Thanks! |
Allow config to not inject the exception hooks
|
Merged - thanks! Will be part of the next release (1.2.8) which should be later this week. |
|
sweet! thanks a lot, looking forward to it :} |
|
Released in 1.2.8 |
This is helpful when you want to add the Rollbar middleware yourself so you have better control as to where it goes in your stack.