Don't try to truncate payloads with 'trace' if that key doesn't exist. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeandres
force-pushed
the
fix-frames-truncation-strategy
branch
from
a4d9c9a
to
8695ca1
Compare
|
@brianr finally I've rescued the exception, log the error and payload and re-raise the exception. In order to report an internal error for this I'd add a new method process_payload_safely, so the async handlers should call that new method. The behaviour for sync reporting is the same since report rescues and use report_internal_error. |
brianr
added a commit
that referenced
this pull request
Dec 19, 2014
Don't try to truncate payloads with 'trace' if that key doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In normal situations this shouldn't happen never. Perhaps only for message reporting instead of exceptions.