Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sidekiq handler #197

Merged
merged 7 commits into from
Feb 5, 2015
Merged

Commits on Feb 3, 2015

  1. Configuration menu
    Copy the full SHA
    02c927b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc6abeb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93fc5d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2015

  1. Tests for Sidekiq handler

    This covers the core functionality of the handler.
    
    Here are ways the tests could be further improved, which I deemed not worth the effort:
    
    1. Testing if the handler is attached properly for Rails < 3 vs. >=3. I have tested it manually for the >=3 case and it works.
    
    2. higher level functional test in the style of how DelayedJob is tested, where actual failing jobs are queued up:
      https://github.com/rollbar/rollbar-gem/blob/master/spec/rollbar/delayed_job_spec.rb
    
    I didn't do this because it's more difficult to do with Sidekiq, for reasons explored here:
      sidekiq/sidekiq#2128
    jjb committed Feb 4, 2015
    Configuration menu
    Copy the full SHA
    d28f1f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcee4e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2015

  1. Style changes for tests.

    Jon de Andres committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    613a601 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from rollbar/sidekiq-refactor-tests

    Style changes for tests.
    jjb committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    40418c4 View commit details
    Browse the repository at this point in the history