Don't require rollbar/rails on initializer #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollbar::Rails becomes an empty module. That functionality is given by the Railtie. However, seems that in the tests we were calling `Rollbar::Rails.initialize`, so the method has been moved to a spec helper.
| @@ -1,4 +1,3 @@ | |||
| require 'rollbar/rails' | |||
There was a problem hiding this comment.
Will customers that already have this line in their generated initializer need to remove it? If they don't remove it, what will happen?
There was a problem hiding this comment.
The file has not been deleted, so the require itself doesn't generate any error. That file just configured the notifier for rails, framework, logger, etc...But that is actually done in the railtie, what is enough.
jondeandres
added a commit
that referenced
this pull request
Sep 30, 2015
Don't require rollbar/rails on initializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollbar::Rails becomes an empty module. That functionality is given by
the Railtie.
However, seems that in the tests we were calling
Rollbar::Rails.initialize, so the method has been moved to a spec helper.